[Sanitizers] Add support for -sanitize=memtag-stack #85515
+68
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sanitizer adds MTE (memory tagging extension) checks to stack variable accesses. Enablement requires setting an attribute on function definitions, and the instrumentation is added by LLVM.
DanBlackwell
requested review from
ndrewh,
thetruestblue,
usama54321,
wrotki and
yln
DanBlackwell
requested review from
DougGregor,
artemcm and
rjmccall
as code owners
Contributor
Author
|
@swift-ci please test |
| @@ -0,0 +1,11 @@ | |||
| // RUN: %target-swift-frontend -emit-ir -sanitize=memtag-stack -parse-as-library -target arm64-apple-macosx10.9 %s | %FileCheck %s | |||
Contributor
There was a problem hiding this comment.
Small nit: %target-swift-frontend inserts the target for the test configuration, given you're overriding it I think you ought to be able to use just %swift instead.
I think this test should probably also have:
// REQUIRES: CODEGENERATOR=AArch64
// REQUIRES: OS=macosx
hamishknight
approved these changes
Nov 18, 2025
Contributor
hamishknight
left a comment
hamishknight
left a comment
There was a problem hiding this comment.
One small comment, LGTM otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sanitizer adds MTE (memory tagging extension) checks to stack variable accesses. Enablement simply requires setting an attribute on function definitions, and the instrumentation is added by LLVM.
The corresponding swift-driver change is at: swiftlang/swift-driver#2016.
rdar://161721201